Pod Request Access Landing Page with email verify

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  Good effort on this challenge! 👍

  Regarding your question, I usually have a container that set a max-width to 1440px. I don't think it is necessary to create a new layout or design for a screen size above 1440px. So, for a screen size that is above 1440px are going to see a layout horizontally center (sometimes vertically center too).

  Now, some feedback from me.

  • The image-host.jpg is a decorative image. It is not adding useful information for the user and the site will be fine without it because there will be no missing information if the image doesn't exist. So, leave the alt empty.
  • The alternative text for the company logos should not contain any words that are related to "image" such as icon, picture, etc. It's already an image element so the screen readers would tell those images as images.
  • The input-container should be a form element. The input element and the submit button should live inside the form element. So by doing this on JavaScript you can grab the form element and listen for the submit event and then validate the user input.
  • I would recommend using addEventListener instead of using onsubmit attribute on the HTML. It's a good practice to separate the functionality and the presentation on its own file.
  • Also, I highly suggest grabbing the DOM element by using js- classes that is specifically for JavaScript purposes. That way, if you want to refactor the CSS or change the CSS class name, you won't have to worry about JavaScript. By doing this, you are practicing one of the programming principle which is Separation of Concerns.

  That's it! I hope this information is useful! 😁

  Marked as helpful

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the card title needs to be in a heavier font weight.

  Secondly the color of the associated brands needs more opacity since it's not well contrasted

  I hope this helps

  Cheers

  Happy coding 👍

  Marked as helpful

  0