Pod landing page using SCSS & BEM

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Max! 👋

  Congratulations on completing this challenge! 🎉

  I have some feedback on this solution:

  • Accessibility
    • Good job on using landmarks correctly! 👍
    • I would recommend wrapping the logo with link element. Usually, when the user click the logo, it will navigate the user to the home page.
    • Well done on leaving the alt="" empty for all decorative images! 👏
    • Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image. Also, remove the word company from the alternative text.
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (by using Tab key) easily.
    • I would recommend putting an actual space instead of using  .
  • Styling
    • I would recommend using CSS to display the background image outside. This will clean up your HTML.
  • JavaScript
    • const input = form.elements[0]; I would recommend using form.querySelector instead of using referencing the input element with index.
    • Use RegEx to validate the user input. Currently, an email address without TLD(Top Level Domain) is valid (e.g. vanza@email).

  Overall, you have a good HTML markup. 👍

  That's it! Hope you find this useful! 😁

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great job overall man. Keep it up

  1