Design comparison
Solution retrospective
This is my first project with some JS. For some reason I struggled with positioning some of the elements on this page, so I ended up restarting the project to have a clean slate. Things ended up looking pretty good in the end so I'm happy with it. I tried using an inset box shadow on the mobile background image overlay which was something new. Time to press on and get deeper into JS. As always, any feedback is appreciated.
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi there, Nick! π
Nice job on this challenge! π Your solution looks good and is responsive! π
A few things I suggest are,
- Adding
overflow-x: hidden
to thebody
(or something similar) to prevent a horizontal scroll bar from appearing along the bottom of the page at certain screen widths. - Adding a favicon to your site (thereβs one in the free starter files that you can use).
- Adding a little space between the logos at the bottom of the page and the bottom edge of the screen (using margin/padding) so that there's always a bit of room between the two in the desktop layout (even on screens with smaller heights).
- Making sure to remove the error message that gets displayed after the user enters and submits a valid input (at the moment, both the error and success messages show at that point).
- Using the font provided in the starter files for the text of the error and success messages.
Hope those few tips help. π
Keep coding (and happy coding, too)! π
Marked as helpful1 - Adding
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord