Pod - html, css, js

Community feedback

• 

  P

  Katrien Schuermans•1,210

  @katrien-sPosted almost 4 years ago

  Why do you have 3 css-files? What is global, main and reset? It makes it really hard to read your files. You can code this page in one file. I'm curious though to why you choose this approach.

  You work with min- and max-widths in your media-queries. It's better to just start mobile-first and slowly work towards the big screen layout. The resizing works nice, so whatever you did, it works. I suppose you're right though about your code being too redundant. It's one of the catches of css. It's very easy to write too much.

  There seems to be some error in the form-validation. I can't enter an email-address. It immediately triggers an alert and the error-message keeps piling up underneath the form. I can not really help you there, as I am also still struggling with form-validation.

  0

  ---

  

  P

  Jarec Turner•140

  @ormus395Posted almost 4 years ago

  I appreciate the feedback. The 3 files are just organizational tools for me. It's a separation of concerns. Global: handles global components/ styles/ colors. Main: probably named poorly, but as its just a landing page, this file is responsible for handling that single page. Reset: styles responsible for resetting elements and their behavior to handle browser inconsistencies: https://css-tricks.com/reboot-resets-reasoning/

  I definitely need to work on my CSS, it's not my strong suite.

  You're right about the form validation, I accidentally listened to the wrong event on the form (Used click instead of submit). This should be fixed now.

  0