Please review it :)

Community feedback

• 

  Papy NDOYE•70

  @P4P1-NDPosted almost 3 years ago

  Nice work on this challenge. In addition to @Saran pointers, you could also add a vertical margin on mobile and delete it on desktop (maybe on the body) with media queries.

  Marked as helpful

  0

  ---

  

  Mark Wasfy•280

  @MarkWasfy00Posted almost 3 years ago

  @P4P1-ND will do , thank you so much for your help , really appreciated :)

  0
• 

  Saran•460

  @Saran-73Posted almost 3 years ago

  Hi, Mark-Congratulations on finishing this project. Just a few things to mention:

  • Change your container <div> to <main>tag this will solve accessibility issues.

  • You don't have to rewrite block declarations for each class when they have the same value instead you can just use a comma and write like size14,size6,size8{margin: 0 1.5rem;}.

  • Use more meaningful tags, change your box <div> to <section> tag for all three, inside them use <h1>and <p> tags.

  • If you use font-size:1.11vw in the top box for the desktop site and then by adjusting the padding, the font will look much better and closer to design.

  Marked as helpful

  0

  ---

  

  Mark Wasfy•280

  @MarkWasfy00Posted almost 3 years ago

  @Saran-73 first of all thanks so much for your notes , second your tips helped me and made me correct my mistakes in my project that i work on now , thanks again !

  1