My take on meet landing page

Community feedback

• 

  P

  thibault.deverge•290

  @thibault-devergePosted 30 days ago

  Hi Timothe! Hope you’ve been well since the last feedback. You’ve been super active, and it shows! Your solutions are very close to perfect—great job!

  Honestly, there’s not much I can suggest, as your code is clear and well-structured, the design closely matches the original, and it’s responsive across all screen sizes. Bravo! 🙌 Going through your code even taught me something new, like the color-scheme property—very cool!

  A couple of minor suggestions:

  • Instead of naming sections as section_a and section_b, try using descriptive names like hero and features for clarity. It’s a tiny detail, but descriptive naming can be helpful even in smaller projects.
  • For purely decorative images, like the gallery of four photos, consider adding aria-hidden="true" to improve accessibility.
  • I see you’re making great use of SCSS with mixins and variables, which is fantastic! It could also be helpful to use SCSS variables for breakpoint queries. This way, if you need to adjust a breakpoint from 75em to 73em, you’d only need to change it in one place.

  These are very minor points, but I wanted to make sure I had some constructive feedback to offer. You’ve done a fantastic job, and I love the design with the dark background. The code is very easy to read and follow.

  Just one question for my own understanding:

  • Why did you choose the directory name _STYLE_? Is there any particular reason behind it?

  Keep up the amazing work! You’re well on your way, and if your goal is to find a job, I’m sure you’ll be there in no time!

  Marked as helpful

  1

  ---

  

  P

  Timothé Bissonnette•420

  @Fable54321Posted 30 days ago

  @thibault-deverge Thank you for your very helpful feedback. I should have probably renamed my STYLE folder, since it was just for me to visually find it easily, but it wasn't really necessary in the end.

  I am currently trying to learn how to make everything as accessible as possible so all these aria tags recommendations are really welcome, thank you again !

  1