plain html and css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Let me explain, How you can easily center the component for better layout without usage of absolute positioning.

  ---

  • We don't need to use absolute to center the component both horizontally & vertically. Because using absolute will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .card {
  position: absolute;
  left: 50%;
  top: 50%;
  transform: translate(-50%, -50%);
  }
  

  ---

  • Now your component has been properly centered.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• Account deleted

  Hi @ernestoacosta1086 👋🏻,

  Good job on your first submission! You've replicated the design quite closely and your CSS is written cleanly. Well done!

  In terms of best practices, I would suggest:

  • You should look into using semantic HTML elements to improve accessibility. For example, <div class="card"> is better replaced with <main class="card"> to specify it is the main content of the page.
  • You should avoid using px to specify lengths in your layouts. Use em or rem so that the layout is responsive to changing font sizes.
  • There are better ways to center divs in modern CSS. The most common ones use either flex or grid.
  • Consider using custom properties for colours, for better code maintainability.

  Cheers!

  Marked as helpful

  0