Design comparison
Solution retrospective
The solution resembles the given design pretty well and I tried to make it responsive!
What challenges did you encounter, and how did you overcome them?I used media query to make it responsive but still used quite a bit of fixed units and sizes - how do I make it more responsive?
What specific areas of your project would you like help with?How to make it responsive!
Community feedback
- @danielmrz-devPosted 4 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
I have one suggestion:
- When using the tag
<img>
, make sure to set the correct path, otherwise your code won't be able to find the image. And if your code can't find it, it won't show.
š This is your code:
<img src="/assets/images/avatar-jessica.jpeg" alt="person">
š And here's the update with the correct path:
<img src="./assets/images/avatar-jessica.jpeg" alt="person">
The difference is just a dot but it's enough to prevent your image from showing.
I hope it helps!
Other than that, great job!
Marked as helpful0 - When using the tag
- @DylandeBruijnPosted 4 months ago
@gina-wang-1021
Hiya! š
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it. In my opinion your solution is already responsive enough!
Things you could improve āļø
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
By default
block
elements already take up the full height of the content that's inside them, so you don't needheight: fit-content
on your card. -
I like that you use the CSS cascade to write less CSS. Like putting
text-align: center
on the card so all the text inside the card is centered. -
Try turning your links in
a
tags and putting them into a list (ul
). -
Try using relative CSS units like
rem
andem
. -
I recommend looking into CSS resets so it's easier to style your projects!
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! š
Let me know if you have more questions and I'll do my best to answer them. šāāļø
Happy coding! š
Marked as helpful0@gina-wang-1021Posted 4 months ago@DylandeBruijn Thanks so much for the feedback! This has been really useful and I'll definitely look into the recommendations you listed out!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord