Plain Css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Ivan, You have done a good work! 😁

  Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .qrcode-container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Ivan•30

  @shiyifanPosted almost 2 years ago

  @denielden Ty~ I'm new to and interested in html layout. Your advises are very helpful, especially the flexbox advice which center the card vertically and horizontally, :-)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @shiyifan You are welcome and keep it up :)

  0