Design comparison
SolutionDesign
Solution retrospective
Greetings all,
Any feedback is greatly appreciated.
A tip from one beginner to another: Be mindful of div's height while using flexbox. I spent half an hour to figured it out why my background image was showing up in mobile layout. I gave the width not height :)
Best regards, KT
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello, KT! 👋
Nice work on this challenge! 🙌 The card component looks good and is responsive! 👍
Two rather minor things I suggest are,
- Adding a little space between the top/bottom of the card using margin/padding to ensure that there's always a little bit of space between the card and the edges of the screen.
- Perhaps using an
<arcticle>
tag for the card component (since it is a self-contained element) to bump up the semantics of your HTML just a tiny bit. 😉
Keep coding (and happy coding, too)! 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord