Ping-single-column-coming-soon-page

Community feedback

• 

  Rajaul Islam Ratul•1,250

  @ratul0407Posted 12 months ago

  @GermanGuerrero95 congratulations on completing this challenge🎉🎉

  You've done a really great job but you can do better :)

  The fact that you've chosen to use background image for the main image on this challenge, is somewhat inconvenient for a lot of situations. You've set the height 80rem for the 1440px screen sizes which works pretty well. But the image crops itself in screen sizes under 1440px so in order to fix it you can manually set height to the image for all of the screen sizes manually or you just use an img tag if I were you I would pick the second option🌝. Next, all three of the .footer_li elements look good on the 1440px screen but the don't scale pretty well for the other screens. To fix it you can change the height and width for screen sizes below 1440px

  .footer_li {
  height: 5rem;
  width: 5.5rem;
  //with all the other properties you've set
  }
  

  This looks good on my opinion but you can tweak with it and see which matches the design better.🚀🚀

  I hope you found this helpful👍👍

  Have a very nice day and happy coding my friend🌝🌝

  0