Design comparison
SolutionDesign
Solution retrospective
I used this project to try and improve my ability to make websites that only need to take up the available height of the screen, if there's an issue please feel free to leave your feedback.
Community feedback
- @vanzasetiaPosted about 2 years ago
Hello, Shikoto! 👋
Good effort on this challenge! 👍
A couple of things I'd like to suggest are,
- Adding alternative text to the logo image. The most important content on the page is the logo. It's not decorative, and not the one with blank
alt=""
text. Without that information, a screen reader user or a search engine will not know what your site/project is called. - Always specify the
type
of thebutton
. In this case, set the type of them astype="submit"
. It will prevent the button from behaving unexpectedly. - Links must have labels (or text) to be accessible by assistive technologies such as screenreaders. For the social media links, you can use
aria-label
to do that. - Using Regular Expression (RegEx) to validate the user's input. Currently, an email address without the top-level domain (e.g. .com) is a valid email address. For example, user@email is a valid email.
I hope this helps!
Marked as helpful1 - Adding alternative text to the logo image. The most important content on the page is the logo. It's not decorative, and not the one with blank
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord