Ping-comingsoon-challenge (HTML, CSS and JavaScript)

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hey, Lucas! 👋

  It is good to see you completing another challenge! 😄

  I notice that you are still using id to grab an element within the JavaScript even though you were saying that you will use js- classes to do it in future challenges.

  Anyway, some suggestions from me.

  • The alternative text of the logo should not contain the word "logo" and should not be hyphenated (like code). It's because the screenreader would pronounce it as an image and alternative text should be human readable (like the normal text to read). So, "Ping" would be a good alternative text.
  • figure element doesn't need to wrap every img element. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
  • Always specify the type of the button. In this case, set the type of them as type="submit". It will prevent the button from behaving unexpectedly.
  • Each social media icon should be wrapped by an anchor tag. It is actually the social media link of the company.

  That's it! I hope you find this useful!

  0