Design comparison
SolutionDesign
Solution retrospective
First time using Sass.
Community feedback
- @palgrammingPosted over 3 years ago
You seem to be validating your email checking for certain domain extensions this causing a problem cause users could have plenty of other emails with domain extensions that you are failing as improper emails when they are valid
0@shake88juntPosted over 3 years ago@palgramming Thanks, the email validator is pretty bad, but I didn't want to spend much time on it. My regex was simply
/.+@[a-zA-Z]+\.[a-zA-Z]+/
0@palgrammingPosted over 3 years ago@shake88junt it looks like in your JS you are checking for
.com
This was in your JS
let regex = /.+@[a-zA-Z]+\.com/g;
0@shake88juntPosted over 3 years ago@palgramming oh damn, that is a mistake then nice catch
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord