Flex and Email validation test

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your EventListener should be on the form and it should be a submit not a click, since the user is submitting their email.

  More Info:📚

  Click vs. Submit EventListeners

  • The logo, intro heading and paragraph should all be wrapped inside the header element. The header should also located outside the main element.

  • Your email input, “error message" and button needs to be wrapped inside a form and have a visibly hidden label attached stating something like "please enter an email…" for improved accessibility.

  More Info:📚

  MDN Email Input

  • The “illustration” in this component serve no other purpose than to be decorative; it adds no value. Its alt tag should be left blank and have an aria-hidden=“true” to hide it from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The social media icons should have a aria-label to improve accessibility.

  MDN aria-label

  If you have any questions or need further clarification, feel free to reach out to me.

  Marked as helpful

  0

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • NEVER ❌ do this as it creates accessibility issues for users and it is outdated.

  html {
    font-size: 62.5%;
  }
  

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

  Marked as helpful

  0

  

  Julien Kombora•230

  @JulienK94Posted almost 2 years ago

  @vcarames thanks for your feedbacks

  1