Ping single column coming soon page

Community feedback

• 

  Fatlind Shehu•2,230

  @fatlindshehuPosted over 2 years ago

  Hi there,

  Nice job with JavaScript, it works fine, I would make some changes to the design though:

  • The font on the button looks different & the size is too big
  • The input field height needs to be bigger, and the text inside the input needs some left padding
  • Social Icons are smaller & their outline is not that big.
  • I would also recommend taking more care of which HTML element you use, they need to have a semantic purpose.

  For the other parts I think you did great, so keep up the good work...

  Marked as helpful

  1

  ---

  

  Alin Balog•200

  @FabzusPosted over 2 years ago

  Hello @fatlindshehu,

  Thank you, I was kind of putting all my eggs in the Js basket ;p.

  I thank you for your review and great suggestions regarding the design. I'll fix everything this and remember this great comment in the future.

  With great respect, Balog Alin

  0
• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  Marked as helpful

  1

  ---

  

  Alin Balog•200

  @FabzusPosted over 2 years ago

  Hi @mubizzy,

  Duly noted, you have been very helpful. Thank you for your kind words and that amazing documentation.

  With great respect, Balog Alin

  0