Design comparison
SolutionDesign
Solution retrospective
hello there I have finished this challenge. please your feedback about this solution. thankyou
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- An error message should display when no email is not entered.
- When the user enters a valid email, I recommend adding some sort of confirmation stating that the email is valid to improve user experience.
Here is an example of how it can look: Example
- The
form
should be inside themain
element.
- The “illustration” in this component serve no other purpose than to be decorative; it adds no value. Its
alt tag
should be left blank and have anaria-hidden=“true”
to hide it from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The social media icons should have a
aria-label
to improve accessibility.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0@moe-kaPosted almost 2 years ago@vcarames for the first point I forgot to add an error message whereas the required pop up message of input html had been hidden, thanks bro have been reminded. I will improve it 🤗👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord