Submitted about 3 years ago
Ping Single Column Coming Soon Page using flexbox
@robpan38
Design comparison
SolutionDesign
Solution retrospective
- any feedback is welcome uwu
Community feedback
- @A-amonPosted about 3 years ago
404 repository link 😂
0@robpan38Posted about 3 years ago@A-amon hahaha forgot to put the repo on visible
0@A-amonPosted about 3 years ago@robpan38 Yea, the invisibility cloak has been taken off now! 😂 Anyway, great work on this one. The responsiveness is good too~
Here are few suggestions:
- Use
border-radius:50px;
to make it pill-shaped as shown in the design - Maybe add some vertical padding to the button on mobile size 📱
- Use
<form>
for your .form instead of a div. (P.s. this allows me to submit by pressing Enter too, other than clicking the button!) 😉 <h1>
might be more suitable for .launch instead of<p>
(Not sure about this tho!)- Don't miss out on the labelling for input! You can use
aria-label
attribute or make the<label>
invisible but readable to screen reader. Reference - Wrap the icons in
<a>
because they should be links. 🔗 - Add alt text to images. (Keep the value as "" (empty) if the images should be hidden from screen reader 👻) Example:
<img src="../image1.png" alt=""/>
- Try to avoid setting the styles directly inside Js if possible. You can add/remove or toggle class names instead. (This way, you can keep the CSS separate from Js)
- fct is a very unclear function name 😀
Extra resource (s):
Form validation0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord