Ping single column coming soon page SCSS and Vanila JS

Community feedback

• 

  Shchetkov Maksim•470

  @ArmsAndArrowsPosted over 1 year ago

  Hi! I like your solution. One thing I can offer - when error message displays - it pushes image down. Toggling class that shows image could be placed not to the whole container but only to the message. And message could have reserved space for it or absolute position to relative position of its parent. Cheers!

  Marked as helpful

  1

  ---

  

  P

  Franci Melink•400

  @francimelinkPosted over 1 year ago

  @ArmsAndArrows Thank you. I think I will use your advice. :D

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 1 year ago

  Heyo,

  It looks really neat! There's really only a few small things you could improve:

  • The box-shadow on the input could be a bit more subtle.
  • It's not a bad idea to add a label to input elements that describes what the user should type in (placeholders are not reliable for this purpose). Since in this challenge the label isn't visible, you can hide it with a screen-reader-only class, like so:

  .sr-only {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px;
  overflow: hidden;
  clip: rect(0,0,0,0);
  border: 0;
  }
  

  • It's great to see you added aria-labels to your links, though they could be as easy as "Facebook", "Twitter", etc.

  Everything else seems good to me, well done!

  Marked as helpful

  0