Email validation using JavaScript

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hey there, Michelle Wayua! 👋

  Good effort on this challenge! 👍

  The reason your JS isn't working may be because you are calling your require function before your script is loaded. Instead of calling the function immediately by placing parentheses after it, try putting the name of the function only there instead. So instead of onsubmit="required()" try onsubmit={required} instead. 😉

  Besides that, a few things I'd like to suggest are,

  • Taking another look at the responsiveness of your site. Currently, it looks good in the desktop view, but things begin to look a bit unorganized in the mobile view. Even if the desktop and/or mobile views of your site look good, it is important to make sure that your site looks great across all screen sizes so that as many people as possible can enjoy your work. If you’d like to learn more about how to make your site responsive, check out this helpful course.
  • Setting the alt text for the social media icon images to be an empty string so that it will be ignored by screen readers. That’s because images should always have alt text but those images in particular aren't necessary or important to the content of the page and as a result doesn’t need to be read by screen readers.

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0

  ---

  

  Michelle Wayua•150

  @MishywayuPosted almost 2 years ago

  @ApplePieGiraffe Hello. Thank you for the feedback. I really struggle with responsive web. I will check out the resources you've sent and try out again. Thank you.

  1