Ping single column coming soon page

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Yeah, nice job, Adriana Eka Prayudha! 👍

  Your solution looks pretty good and responds nicely! 🙌

  Just make sure (in addition to following artimys' helpful suggestions) you make your input element accessible (you might be able to turn the "Subscribe and get notified" element into a label or something) and this StackOverflow query might help you resolve the other HTML issues in your solution report.

  Keep coding (and happy coding, too)! 😁

  0
• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Nice job Adriana, solution responds well.

  Some minor suggestions:

  • I'm glad to see you're using semantics but I believe your <footer> should not be a child in the <main> container. As is it gives the meaning that your footer content is part of the main topic of your content. I try to keep header, main, and footer adjacent to each other.

  • In your JS, I suggest creating a class for your form and apply the email and small styles.

  Great job overall 👍👍

  0