Ping Single Column Coming Soon Page

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hi,

  Great work on this one. And congrats on writing your own regex. ^^ I suppose you know it already that an email regex should be more complex than this to cover more use cases, but for learning purposes it's awesome you wrote your own!

  Your solution looks good on all screen sizes. I only have a few small feedbacks to give.

  1. You wrapped everything in a container div which isn't necessary. All the styles you applied there can be put on the body itself.

  2. Footer social links: they're wrapped in a div but a ul would be more appropriate here.

  3. Alt texts: I tend to share this article with everyone since I read it. It's a great summary on how to write good alt texts (similar goes to your aria-labels: no need to specify they're describing links, using the <a> tag should make this obvious enough. So instead of writing "link to facebook website", simply "Facebook" is good enough!).

  Also, I found none of the issues the accessibility report mentions, perhaps you need to just generate a new report to get rid of the problems ^^

  Again, good job on completing the challenge and good luck with the next one :)

  Marked as helpful

  1

  ---

  

  Chris•400

  @chrisvn188Posted almost 3 years ago

  @FluffyKas Hi I really appreciated your time to give me feedbacks on this. It's really helpful to me.

  • Last challenge, I copied email regex from StackOverFlow and it's much longer than mine. But I did not understand it. I decided to learn regex from FreeCodeCamp and know the basic of it. Now I can read it and understand :). I need to practice it a lot.

  • Thank you for sharing that great article about alt text. I'll read it and share to people like me with that issue.

  • Have a great week! and Happy Coding!

  1

  

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  @chrisvn188 Haha, yeah, I did the same course of freeCodeCamp a few weeks ago, it was interesting but also pretty complicated ^^ So it's awesome you could come up with a regex on your own!

  0

  

  Chris•400

  @chrisvn188Posted almost 3 years ago

  @FluffyKas I use this website to pratice too https://regexr.com/. I try to apply what I learn so far to create simple one. I feel great when It works :))

  0

  

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  @chrisvn188 That looks very useful, I'll be sure to play around with it ^^ Thank you!

  0

  

  Chris•400

  @chrisvn188Posted almost 3 years ago

  @FluffyKas I read the article that you share. It's actually what I'm looking for. I'm learning accessibility but there are tons to learn. But I think learning it a little at a time maybe better. I learned something new today thank to you.

  0