Ping single column coming soon page

Community feedback

• 

  P

  Azzumar•340

  @AzzumarithmPosted over 1 year ago

  The image doesn't appear. There's no images being pushed to the repository.

  Marked as helpful

  0

  ---

  

  HyunSeo Oh•10

  @1309042Posted over 1 year ago

  @Azzumarithm Oh! I thought the image folder would be pushed together, but it wasn't! Thanks for your help. Let's find out how to push the folder right now

  0

  

  P

  Azzumar•340

  @AzzumarithmPosted over 1 year ago

  @1309042 The first way you can do is to upload the image folder within the project folder and add it, make a second commit and push it to your repository. You do it in a terminal or if you're using vscode there's a gui for it, depends on your preferences. I prefer using terminal. Again, make sure the path and the directory is correct, if not make the necessary changes and repeat the process. If that doesn't work out then you can just upload the image folder directly onto your github(there's an "add file button") but make sure the src path is accurate otherwise you can just directly edit it on your github. Good luck!

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by wrapping the whole content using proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  HyunSeo Oh•10

  @1309042Posted over 1 year ago

  @0xAbdulKhalid Wow! Thank you for this detailed solution! Your solution will be a big shortcut to my first step! I am not good at English because I am Korean, but I hope you know that your help was very helpful to me Thank you!!!!!^ㅠ^

  0