Ping single column coming soon page

Community feedback

• 

  Cacti•390

  @nottohavePosted over 2 years ago

  Hi Sebastian, the website looks great on my devices. It is responsive and has great layout. Your index file has semantic HTML. The code is well-structured and readable. I think there are a couple of improvements you can make, let me know if they help you:

  • In larger screen, you can add more padding to the logo on the top : header img {margin: 45px 0px}. This is just a preference, you can use a different unit if needed to.
  • For the error label, there is another approach instead of using JS DOM. You can take a look at this video class list. I hope it will give you an idea of creating a class in Style file. Then you use your JS email validation to add and remove the Class List. This is to display and remove the error label. This method is a lot more simplified and versatile.

  Have a great weekend, and let me know if these tips help you. Thank you :D

  Marked as helpful

  1

  ---

  

  Sebastian•300

  @sandlerzPosted over 2 years ago

  @nottohave thanks Fay D, the video was very useful, It's easier that way. I appreciated it. when I was working on the challenge, I was thinking and looking for a way to do it, but I didn't know how to look up information.

  have a great weekend too!

  (I'm trying to learn English)

  1