Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox and Sass

dralveol 160

@dralveol

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Encountered problems with css specificity because of nesting. Organizing code with sass and nesting, good or bad practice ?

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • Your EventListener should be on the form and it should be a submit not a click, since the user is submitting their email.

More Info:📚

Click vs. Submit EventListeners

  • The logo, intro heading and paragraph should all be wrapped inside the header element.
  • Every image, illustration, icon, etc… should always have an alt tag, regardless if it is decorative or not.
  • The only heading in this challenge is "We are launching soon!". Every other text should be wrapped in a paragraph element.
  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

Marked as helpful

1

dralveol 160

@dralveol

Posted

@vcarames Thanks a lot for the well structured feedback

0
Nikola D 1,450

@NikolaD93

Posted

Hello there! 👋

Congrats for completing the challenge! 🙌

I have a suggestion for you:

1.Make sure to write some description of an image in the alt attribute. 👇

https://www.w3schools.com/tags/att_img_alt.asp

About nesting with SASS, yes it's a good practice, that's also a huge benefit when working with SASS.

Have a nice one! 🎉✌

1

dralveol 160

@dralveol

Posted

@Nikola1232456 Thank youu for the feedback

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord