@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Your
EventListener
should be on theform
and it should be asubmit
not aclick
, since the user is submitting their email.
More Info:📚
Click vs. Submit EventListeners
- The logo, intro heading and paragraph should all be wrapped inside the
header
element.
- Every image, illustration, icon, etc… should always have an
alt tag
, regardless if it is decorative or not.
- The only heading in this challenge is "We are launching soon!". Every other text should be wrapped in a
paragraph
element.
- For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@dralveol
Posted
@vcarames Thanks a lot for the well structured feedback