Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- This all needs to inside a
form
element:
<input id="email" type="email" placeholder="Your email aderess"> <p class="error">please provide a valid email adress</p> </div> <button target="" class="button">Notify Me</button>
- The
input
needs to have a visually hiddenlabel
attached to improve accessibility.
- The social media icons should have a
aria-label
to improve accessibility.
- Your email validation needs to be update, since it is currently thinks every email is invalid. It needs to look for a
form
submission:form.addEventListener("submit", (e) =>
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - This all needs to inside a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord