ping-coming-soon-page

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The main element should only be wrapping the form and illustration.

  • These need to be inside the header element:

  <h1 class="primary__title">We are launching <span>soon!</span></h1>
  <p class="primary__text">Subscribe and get notified</p>
  

  • The label inside your form is for accessibility, to tell users what the input is for, not for an error message.

  • The `labels in this challenge would state something like, "Enter email…" and be visually hidden.

  • The social media icons should have a aria-label to improve accessibility.

  MDN aria-label

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  1

  ---

  

  Sami NASRI•240

  @SilverWings47Posted almost 2 years ago

  @vcarames Thank you! I just made all the changes you suggested.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @SilverWings47

  Glad I could help!☃️

  Keep it up!

  1