Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ping-coming-soon-page

Sami NASRI 240

@SilverWings47

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be highly appreciated.

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The main element should only be wrapping the form and illustration.
  • These need to be inside the header element:
<h1 class="primary__title">We are launching <span>soon!</span></h1>
<p class="primary__text">Subscribe and get notified</p>
  • The label inside your form is for accessibility, to tell users what the input is for, not for an error message.
  • The `labels in this challenge would state something like, "Enter email…" and be visually hidden.
  • The social media icons should have a aria-label to improve accessibility.

MDN aria-label

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

1

Sami NASRI 240

@SilverWings47

Posted

@vcarames Thank you! I just made all the changes you suggested.

1

@VCarames

Posted

@SilverWings47

Glad I could help!☃️

Keep it up!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord