First project using HTML, CSS and JS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your EventListener should be on the form and it should be a submit not a click, since the user is submitting their email.

  More Info:📚

  Click vs. Submit EventListeners

  • The logo, intro heading and paragraph should all be wrapped inside the header element.

  • Your email input, “error message" and button needs to be wrapped inside a form and have a visibly hidden label attached to it for improved accessibility.

  More Info:📚

  MDN Email Input

  • The social media icons should have a aria-label to improve accessibility.

  MDN aria-label

  • When the user enters a valid email, I recommend adding some sort of confirmation stating that the email is valid to improve user experience.

  Here is an example of how it can look: **Example

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  0