Skip to content
Submitted about 2 years ago

Ping single column coming soon page

Lawrence Caudle•100
@ltc870
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Ping single column coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Another project down. I'm currently learning React, so that was the goal for this project. Of course, constructive feedback is welcomed. Please let me know how I could improve this project, or if there's better ways in writing the code. I'd greatly appreciate it!

Community feedback

  • Adriano•38,270
    @AdrianoEscarabotePosted about 2 years ago

    Hi Lawrence Caudle, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    1
    Lawrence Caudle•100
    @ltc870Posted about 2 years ago

    @AdrianoEscarabote Hey!! Thanks for the advice, I really appreciate how detailed you are with this critique. I was wondering, is using elements like <details>, <figure>, <summary>, etc. not semantic HTML? Do they not tell the screen reader where the user is at in the document? Or do I need to use the "big" headings like the ones in your examples above? I guess I always thought that the other semantic HTML carried as much weight as the others but I guess not, if that makes sense.

    1
    Adriano•38,270
    @AdrianoEscarabotePosted about 2 years ago

    @ltc870 It's good that you make use of both!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord