Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping Single Column Coming Soon Page

@yunusemrecinar

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi Yunas,

Congratulations 🎉 for completing this challenge, it was a great attempt. The web page looks good however, there are some issues I want to address.

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. When clicking on the button with no content in the input field, the error message shows however when clicked again, the message goes away. This acts as a toggle feature however the message should go once the email is valid.

Overall, great attempt and wish you the best for your future projects so keep coding 👍.

Marked as helpful

0
Lucas 👾 104,420

@correlucas

Posted

Hello Yunus, congratulations for your new solution!

I've checked your main.css file and I saw you're not using a modern css reset, that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

Think about adding that for your next project.

Hope this helps, happy coding 👏

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord