Design comparison
Solution retrospective
Hi here is my solution for "Ping single column coming soon". I used HTML, CSS, Flex, Grid, Mobile-first, JS.
What challenges did you encounter, and how did you overcome them?I used a span
and a listener to display the error message with innerText
and an if
to validate the form if(!myForm[0].validity.valid)
.
Thanks to leave any comment if you see something I can do better.
Community feedback
- @ilyesabPosted 8 months ago
Great Work! I think the only thing that seemed a little bit odd in layout terms was that you have no margin around the content on Mobile. so the logo and the copyright sticks to top/bottom of the view port looks a little bit odd.
You created the spacing mainly using margin and used the position property to position the error message. all looks good for me using the validity API was a great idea.
Maybe something to try next is that your design doesn't change from 0px width to 1200px. it's static as you used a lot of max-width I understand that was intentional. but it'll be great if the design changed to best utilise the available space in the view port.
Marked as helpful1@Lo-DeckPosted 8 months agoHi @ilyesab, thanks for your feedback.
I've just tried on my mobile, it looks weird with no margin(couldn't see that with browser tools). It's better with a margin.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord