Ping page with Grid

Community feedback

• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Nice job Fawad, the error message effect is really fancy 👍

  Your form responds well but your image responds toooo well that it gets really small or large. I would either putting a max-width on your main container or to the parent container of your image. Actually your main container can benefit also as everything gets really stretched out on wider screens.

  The h1 text can better a bit more larger and the subscribe text doesn't have to be too bold.

  Javascript:

  • It's great that you added your styles to a classes to activate. To improve on it, create an .form-errors class toyour form. Inside that class place your other styles that style the border and show the message. That way only one class actives the styling errors.

  • You can clean up your nested if statements with just one if else if statement.

      if ( input.value == '' ) { 
           // code
      } else if ( !validateEmail(input.value) ) {
          // code
      }
  

  Keep on coding!! 👍

  0

  ---

  

  Fawad Mehmood•410

  @fawadmehmoodPosted almost 4 years ago

  hi @artimys, thank you very much for this feedback. I will definitely make these changes.

  0