Submitted over 3 years ago
Ping comng soon page with HTML, Sass, and JavaScript
@rngueco
Design comparison
SolutionDesign
Solution retrospective
Hi Frontend Mentor community!
I've finished another challenge. This one is a relatively easy project for me layout-wise, but I had wanted to practice more on my JavaScript skills so I figured I should go for it anyway.
Feedback on any part of my code is appreciated!
Community feedback
- @mattstuddertPosted over 3 years ago
Nice work, Riyana! Your project looks great! Here are a few small pieces of feedback:
- Instead of leaving the logo
alt
text blank, I'd add the name of the company. So, in this instance, it would bealt="Ping"
. That would help screen readers users know what the site is. - This is a small UX thing but I'd avoid removing the error message on input focus. The error message is there to help guide someone, so it helps to keep it visible until the error has been resolved.
- When adding error messages, you can use the
aria-live="polite"
attribute to ensure updated messages are announced to screen reader users. This is a big help when form validations kick in.
I hope those points help. Let me know if you have any questions!
Marked as helpful0@rnguecoPosted over 3 years ago@mattstuddert That makes a lot of sense. Thank you, Matt!
Thanks also for informing me about
aria-live
, I didn't know about that beforehand.Changes should be up in a few. Cheers!
0 - Instead of leaving the logo
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord