Ping Coming soon using Html and Css

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, TechnoSolution! 👋 Congrats on finishing another challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Change the alt attributes for the .logo, and .illustration as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • You shouldn't using descendant selectors like this .social-list ul li i. It will lead to problems later on if you want to overwrite something in your code. Instead add class to element you want style.
  • First icon circle isn't perfectly rounded. This is because you apply border on icon, instead of parent element with set width/height. And since your icons have diffrent weight/height your border circle isn't same for all of them.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  TechnoSolution•125

  @MuhammadLaeeqPosted over 3 years ago

  @tediko thanks a lot for your advice

  0