Ping coming soon page

Community feedback

• 

  P

  Simon•150

  @Simplify4Me2Posted 3 months ago

  Hello @jjdavenport,

  Congratz on completing the challenge! It looks good 👍

  I noticed that the current workflow isn't mobile-first, which might be why the mobile design lacks margins and has larger font sizes. Shifting to a mobile-first approach could help optimize the layout for smaller screens. You could also consider the PerfectPixel browser extension to ensure your design matches the mockups more precisely.

  You've definitely paid good attention to semantic HTML. The header tag is currently in the main tag, though. Typically, the header should be a sibling of main rather than a child to maintain proper semantic structure. Also, the ul element used for social media icons could be more appropriate as a nav element, indicating these icons are a form of navigation.

  In React, your approach of having components depend directly on assets/data.json might reduce flexibility. Passing this data through as props could enhance the reusability of your components. The validation logic you've implemented looks like a great candidate for a custom hook. This could keep your components clean and focused.

  Keep up the great work and happy coding ⚡⚡

  Marked as helpful

  1