Ping-coming-soon-page with client-side data validation

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,780

  @catherineisonlinePosted about 2 months ago

  Hello there, nice solution!

  • You might have missed it but you accidentally or did not, create a global variable right inside the function, which makes no sense. Maybe better to move it from there or just pass directly the input.value?

  form.addEventListener("submit", (evt) => {
    THIS ONE 👇
    email = input.value;
    if (isValidEmail(email)) {
      removeErr();
  ....
  

  • I wonder why you set value of the input to null if by default it's string type? I guess it's better to reset it back to string unless there are other intentions. 😅 And you might not need the evt here either

  window.addEventListener("load", (evt) => {
    THIS ONE 👇
    input.value = null;
    removeErr();
  });
  

  • You might need to move away preventDefault in the form submission out of the else block as it will work only when the form is invalid. Otherwise, when I successfully submit the form, it tries to make a post request which isn't functional and breaks the page 😵

    if (isValidEmail(email)) {
      evt.preventDefault();
      removeErr();
      alert("Email address is valid");
    } else {
      if (!email) {
        addErr("Whoops! It looks like you forgot to add your email");
      } else {
        addErr("Please provide a valid email address");
      }
    }
  });
  

  Marked as helpful

  1