Ping Coming Soon page using Tailwind-css

Community feedback

• 

  Saurabh Singh•140

  @saurabhgithbPosted about 2 years ago

  Hello Shiva, I think your code can be optimized as:- a) remove separate markup for each error message instead set error message in js using a setError function. b) pass the message in setError function and use it to add innerText and styles for different error in js. c) make the div containing error message absolute and position it correctly. You can use the same for success message also. This will save use hide/unhide logic.

  Marked as helpful

  0

  ---

  

  Shiva•670

  @shivaprakash-sudoPosted about 2 years ago

  @saurabhisdev

  Hello Saurabh,

  That makes more sense and easy it to maintain, thank you for the suggestion. :)

  0
• 

  Icaro Mendes•240

  @icaroMendes777Posted about 2 years ago

  In general looks good. But if you wanna some sugestions:

  • the standard validation to input email is over the red message suggested in the design, you can change the input type from email to text, so this validation wont be triggered

  • the if statement if (emailInput.value === "" || emailInput.value === null) can be stated just if(!emailInput.value )

  but, yeah, there is not much to say. I think it is good.

  Marked as helpful

  0

  ---

  

  Shiva•670

  @shivaprakash-sudoPosted about 2 years ago

  @icaroMendes777

  Thank you for the useful suggestions.😊

  1