romila• 3,570
@romila2003
Posted
Hi Olamide,
Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great however there are some issues I want to address.
- It is great that you used the right semantics for the
header
and thefooter
however the main content is missing a semantic therefore I would suggest you wrap the main content within themain
tag. - Also, I noticed that you used a desktop-first approach and not the mobile-first approach. It is best practice to use the mobile-first approach as it would be easier to rearrange your layouts, as the screen size increases. For your future projects, I hope you consider this and there are many resources that can help you with this concept if you are unsure of this concept.
- I've also noticed a lot of white space around your image that causes the
footer
to be quite down as a result of this. It may be best to remove theheight
property to reduce some space.
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
Marked as helpful
0
OLUMIDE MICHEAL• 270
@codewithmide
Posted
@romila2003 Thank you for the corrections. I will do the necessary ones now and take others into consideration when doing new projects
1