Design comparison
SolutionDesign
Solution retrospective
Feedback welcome.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi there! 👋
It's nice to see you completing another challenge! 👏
Some suggestions from me.
- All the social media icons are not showing up. To fix this, I recommend only downloading the needed icons instead of importing all the font awesome icons.
- In addition to the previous feedback, the social media links have no text content which means they are not accessible by the screen readers. So, I recommend adding an
aria-label
to each link. The value for thearia-label
is just the social platform name (Facebook, Twitter). - Alternative text for images should not contain any words that are related to image. It's already an image element so the screen reader will pronounce it as an image (the same logic apply to link).
- For the email input, the input type should be
email
instead oftext
. Mobile users rely on the virtual keyboard and the virtual keyboard layout can adapt through different input types (like having@
key if it is an email input or showing only number keys for phone input). This will make it easier for mobile users to fill the input.
That's it! Hope this helps. 😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord