Design comparison
SolutionDesign
Solution retrospective
What specific areas of your project would you like help with?
feedback on my code, if there are better ways to improve on it
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
PROPERLY LINKING LABELS 🔖:
input
elements wants alabel
associated with it in a proper way, adding alabel
without proper association with it'sinput
element does not work.
- Currently you only added
id
attribute forinput
element but you forget to addname
attribute.
- The
id
of a input element has nothing to do with the data contained within the element. IDs are for hooking the element with JavaScript and CSS.
- The
name
attribute is used when sending data in a form submission. Different controls respond differently. For example, you may have several radio buttons with differentid
attributes, but the samename
. When submitted, there is just the one value in the response - the radio button you selected.
- So please add
name
attribute ofemail
forinput
element to link thelabel
properly.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord