Design comparison
SolutionDesign
Solution retrospective
Hi, Iām Galih š«”, and this is my solution for this challenge. ā
Build with:
- Next
- TypeScript
- Tailwind CSS
This is the first time I am using TypeScript, any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you.šā¤ļø
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS š:
- The
h-screen
utility class is used to defineheight: 100vh
, But we want to usemin-height: 100vh
fordiv
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thediv
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then thediv
will start at100vh
, if the content pushes thediv
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
- So we want to use
min-h-screen
utility class to definemin-height: 100vh
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@chadittyaPosted over 1 year agohello @0xAbdulKhalid thank you so much for the insight, this will be help me a lot for future projects
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord