Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping coming soon page solution

Galih Arizzaā€¢ 230

@chadittya

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, Iā€™m Galih šŸ«”, and this is my solution for this challenge. ā­

Build with:

  • Next
  • TypeScript
  • Tailwind CSS

This is the first time I am using TypeScript, any suggestions on how I can improve and reduce unnecessary code are welcome!

Thank you.šŸš€ā¤ļø

Community feedback

@0xabdulkhaliq

Posted

Hello there šŸ‘‹. Congratulations on successfully completing the challenge! šŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS šŸ“:

  • The h-screen utility class is used to define height: 100vh, But we want to use min-height: 100vh for div instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
  • For example; if we set height: 100vh then the div will have 100vh height no matter what. Even if the content spans more than 100vh.
  • But if we set min-height: 100vh then the div will start at 100vh, if the content pushes the div beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.
  • So we want to use min-h-screen utility class to define min-height: 100vh

.

I hope you find this helpful šŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Galih Arizzaā€¢ 230

@chadittya

Posted

hello @0xAbdulKhalid thank you so much for the insight, this will be help me a lot for future projects

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord