Ping Coming Soon Page Master (HTML+CSS+JS)

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  so on a fresh page load [email protected] passes your email validation test then if you remove the .com and submit again it fails BUT THEN if you type the .com and submit again then it still fails

  so you email validation logic still needs a little work

  1

  ---

  

  Luis•270

  @luibernipPosted over 3 years ago

  Hello @palgramming , thank you for reviewing my code and helping me in this journey. I noticed what you said and tryid to change the code with a new else in the checkInput function.

  function checkInput() {
    const emailValue = email.value.trim();
  
    if (!emailValue) {
      setErrorFor(email, 'Whoops! It looks like you forgot to add your email');
    } else if (!isEmail(emailValue)) {
      setErrorFor(email, 'Please provide a valid email address');
    } else {
      alert('Success');
      email.value = '';
    }
  }
  

  I'm not quite sure on what is the most appropriate way to see if it is working or not. But I think it works. If you have time I would be thankful with you if you can try it one more time.

  Thanks

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @luibernip yes the problem I see is that in your success logic you are not removing the error status if it was previous set but you have made progress

  0