Design comparison
Solution retrospective
I have just create this using html, css, and vanilla JS.
Any feedback would be greatly appreciated
Thankyou
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, your solution looks good, seems responsive as well! I have a few suggestions for you though:
-
Your title's font-size could be a bit bigger in desktop view.
-
Although the accessibility report doesn't pick this up for some reason, your input could be a bit more semantic. Instead of a
div
named input, you could actually useform
. There's also a semantic tag for buttons, calledbutton
, I'd encourage using this rather than an button type input. -
Your social links have aria-hidden on them. Since your aim here should be to provide text information and not to deny access to certain functions, aria-labels would be more appropriate!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord