Ping Coming Soon Page (SASS + Vanilla JS)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 8 months ago

  Welcome Back Lucas 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  SOCIAL ANCHOR 🔴:

  • The social svgs are need to be wrapped with a element, because those svgs are not for decorative purpose they are links which helps visitors to navigate to a corresponding page.

  ---

  • All of the <a> elements must need to have aria-label attribute which is way more important for social links in an <a> tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.

  ---

  • When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an aria-label attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.

  ---

  • By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.

  ---

  • Example:

  <a href="#" aria-label="Facebook profile of Ping">
      <svg>Facebook Svg...</svg>
  </a>
  

  ---

  • An important thing to note here is you haven't utilized ul element since it's child needs to be li elements so don't forget to wrap a tags within li element.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Lucas 👾•104,340

  @correlucasPosted 8 months ago

  Thank you bro! @0xabdulkhalid

  0