Design comparison
Solution retrospective
Ping Coming Soon Page - FrontEnd Mentor
Community feedback
- @mattstuddertPosted over 4 years ago
Nice work on this challenge, Matas! I'd recommend taking a look at the report and try resolving the accessibility and HTML validation errors. Keep up the great work! 👍
1 - @shubhamthedevPosted over 4 years ago
Hi Matas, nice work on the design, it is responsive and looks good on most view-port sizes. Here some suggestions for you:
-
You should probably give some
margin-right
on the social icons they are sticking really close to each other. -
You should give a
cursor:pointer
to your button element. -
Always provide
alt
attribute to your images since they're important for screen readers and for general accessibility purposes. -
Input should always have a label with them and can be hidden in CSS.
-
The input type should be email since you are taking the email address from the user not text and this provides some basic HTML5 validation.
Overall nice job and keep coding 😊
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord