Design comparison
SolutionDesign
Solution retrospective
Hello everyone,
I am Namrata and this is my solution for the Ping coming soon page challenge.
If you have any suggestions to improve my code, please feel free to share!
Thank you 🙏
Community feedback
- @matiasluduena23Posted about 1 year ago
Hi Namrata. Good Work! Just one good practice that might help you in this and future projects.
- When you used a form, all your inputs, button and error message are wrapper inside the form, because some of this data you are going to send data to some endpoint server. Here Docs.
- And for the error message notice that when it appears the image jump a few pixels down, that is because you use a position static in the
<p>
element. My recomendation is:
- Replace the
<p class="error-msg">
for a<span class="error-msg">
- Use position absolute in that
<span class="error-msg">
- Use position relative to the parent, the form.
- Use top, left, right, botton to position your
span
element under the input.
Position absulute resources
Hope this help you!
Good code!!!
Matias
Marked as helpful0@nmrtsnhPosted about 1 year ago@matiasluduena23 Thank you for the feedback! I'll fix these issues and keep in mind for future projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord