Ping Coming Soon Page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Elysson Tanaka! 👋

  Congratulations on finishing this challenge! 👏

  I have a few suggestions for this solution.

  • For the logo, I would recommend improving the alternative text by telling the users the company name which is "Ping". This will help users know that they are on the Ping site or the site is called Ping.
  • figure element doesn't need to wrap every img element. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
  • I would recommend moving the button inside the form element. Also, add the type="submit" to the button element.
  • Avoid using JavaScript to add styling (unless you've no other option). JavaScript allows you to change the CSS code using the style property. But, to make debugging easier and improve code maintainability, it’s best to avoid it. Use CSS classes instead.

  I hope this helps! 👍

  Marked as helpful

  0

  ---

  

  Elysson Tanaka•90

  @elyssontanakaPosted over 2 years ago

  @vanzasetia thank you so much for your feedback! I'll take those suggestions in consideration in future projects! I'll fix my code as well 😀

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @elyssontanaka No problem! 👍

  0