Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping Coming Soon Page

Elysson Tanakaβ€’ 90

@elyssontanaka

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my solution to the Ping Coming Soon Page challenge. Any feedbacks are appreciated!

Thanks!

Community feedback

Vanza Setiaβ€’ 27,795

@vanzasetia

Posted

Hi, Elysson Tanaka! πŸ‘‹

Congratulations on finishing this challenge! πŸ‘

I have a few suggestions for this solution.

  • For the logo, I would recommend improving the alternative text by telling the users the company name which is "Ping". This will help users know that they are on the Ping site or the site is called Ping.
  • figure element doesn't need to wrap every img element. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
  • I would recommend moving the button inside the form element. Also, add the type="submit" to the button element.
  • Avoid using JavaScript to add styling (unless you've no other option). JavaScript allows you to change the CSS code using the style property. But, to make debugging easier and improve code maintainability, it’s best to avoid it. Use CSS classes instead.

I hope this helps! πŸ‘

Marked as helpful

0

Elysson Tanakaβ€’ 90

@elyssontanaka

Posted

@vanzasetia thank you so much for your feedback! I'll take those suggestions in consideration in future projects! I'll fix my code as well πŸ˜€

0
Vanza Setiaβ€’ 27,795

@vanzasetia

Posted

@elyssontanaka No problem! πŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord