Skip to content
Submitted over 3 years ago

Photosnap Website

trudihub•140
@trudihub
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Photosnap multi-page website
  • HTML
  • CSS
  • JS
4advanced

Design comparison

SolutionDesign

Solution retrospective

Hey everyone, I built this photosnap site with react and styled-components. Mainly used grid layouts. Any feedback is appreciated !

Community feedback

  • Marko Nikolajević•1,065
    @MarkoNikolajevicPosted over 3 years ago

    Hi trudihub, you did a great job on this challenge! I like it!

    Your code is clear and clean, I just have a feedback for you. On laptops view the text inside divs with description class is squeezed. I think is because you set a media queries too early @media (min-width: 1024px).

    Anyway you did a great job!

    Keep on coding and have fun!

    1
    trudihub•140
    @trudihubPosted over 3 years ago

    @MarkoNikolajevic Yeah, you're right, thanks for the feedback! I didn't pay close enough attention to resizing windows on desktop devices. How would you adapt the breakpoints to solve this ? Kind regards!

    0
    Marko Nikolajević•1,065
    @MarkoNikolajevicPosted over 3 years ago

    @trudihub I usually use a media query for laptops and one for larger screens. For example @media (min-width: 1024px) // laptop and @media (min-width: 1440px) // larger screens.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord