Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Página responsive utilizando display grid para la división de columnas

TITOR 340

@hectorestebanm

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Segundo desafio aportado. Página utilizando display grid para las columnas, lo único que no pude solucionar es que cuando se achica demasiado la página las columnas no se acomodan a pesar de tener repeat(3, 1fr) para generar las columnas.

Cualquier sugerencia es bienvenida, gracias.

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hi TITOR,

Excellent work! I have some suggestions regarding your solution:

HTML

  • It is recommended not to have more than one h1 on the page . Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). Then you can use <h2> instead of those <h1>.
  • In this challenge , all the images are decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .
  • Imagine what would happen when the user click those learn more? Clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>.For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
  • Adding rel="noopener" or rel="noreferrer" to target="_blank" links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

Overall, your solution is great . hopefully this feedbcak helps.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord