PhoenixDev22• 16,950
@PhoenixDev22
Posted
Hi TITOR,
Excellent work! I have some suggestions regarding your solution:
HTML
- It is recommended not to have more than one h1 on the page . Multiple
<h1>
tags make using screen readers more difficult, decreasing your site’s accessibility. You can add a<h1>
withclass="sr-only"
(Hidden visually, but present for assistive tech). Then you can use<h2>
instead of those<h1>
.
- In this challenge , all the images are decorative. For any decorative images, each img tag should have empty
alt=""
as you did andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images .
- Imagine what would happen when the user click those
learn more
? Clicking those"learn more"
would likely trigger navigation not do an action so button elements would not be right. So you should use the<a>
.For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute , you can expose your site to performance and security issues.
Overall, your solution is great . hopefully this feedbcak helps.
0