Página de receta - React Typescript

Community feedback

• 

  P

  Timothé Bissonnette•420

  @Fable54321Posted about 1 month ago

  First comment is going to be about your github management. It might be fine for your own personnal work to have one massive repo for multiple projects, but you should have one per project when publishing a solution. At least in my opinion.

  Second, I can see you are learning react, wich is perfectly fine. It seems obvious to me that your big focus for this one was the usage of props. You have built a json file that you have imported in you app component (by the way your app.tsx is a component, so it should be in that folder ;)). You've sent the props down from the recipe.json file really well.

  For the react side of things I would say you have done a great job, maybe it would be time for you to start looking into css modules wich is a really good way to use css with react.

  Now, I feel like everybody who wants to be a front-end engineer should ear this. You may look at javascript and react and think this is what is going to set you apart, but really the difference between a pro and a hobbyist is mostly in the html and the css.

  If you are taking one of the projects here to practice react, that's a good idea, but don't let it overtake everything else. You will kick yourself when you are a js and react master but you still look like an amateur using html and css.

  Keep up you clearly are capable !

  0