Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Página de receta - React Typescript

@Lombardimn

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

"En este desafío, estoy orgulloso de haber aplicado el uso de mapeos de datos y la descomposición de componentes para tener mayor escalabilidad. Para la próxima, me gustaría poder aplicar estados a los componentes para que sean dinámicos según la receta que quiera consultar y aplicar animaciones.

What challenges did you encounter, and how did you overcome them?

El desafío más grande fue descomponer aquellos componentes que contenían más de un ítem repetitivo.

What specific areas of your project would you like help with?

Me gusataría recibir ayuda con el estilado de mis componentes y del proyecto en general, dado que seguro se pueden aplicar mejores practicas.

Community feedback

P

@Fable54321

Posted

First comment is going to be about your github management. It might be fine for your own personnal work to have one massive repo for multiple projects, but you should have one per project when publishing a solution. At least in my opinion.

Second, I can see you are learning react, wich is perfectly fine. It seems obvious to me that your big focus for this one was the usage of props. You have built a json file that you have imported in you app component (by the way your app.tsx is a component, so it should be in that folder ;)). You've sent the props down from the recipe.json file really well.

For the react side of things I would say you have done a great job, maybe it would be time for you to start looking into css modules wich is a really good way to use css with react.

Now, I feel like everybody who wants to be a front-end engineer should ear this. You may look at javascript and react and think this is what is going to set you apart, but really the difference between a pro and a hobbyist is mostly in the html and the css.

If you are taking one of the projects here to practice react, that's a good idea, but don't let it overtake everything else. You will kick yourself when you are a js and react master but you still look like an amateur using html and css.

Keep up you clearly are capable !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord